Skip to content

chore(examples): integrate in CI flow with lint and build #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 18, 2022

Conversation

flochaz
Copy link
Contributor

@flochaz flochaz commented Jan 10, 2022

Description of your changes

(built on top of #439)

Examples were not linted or built leading to missed bugs and compilation errors.

This PR homoganize the structure of cdk examples as well as make them lint and built the same way as modules.

It also add a job in e2e test workflow to test compilation of future published packages and avoid this kind of needed fix #470

How to verify this change

npm run lerna-lint
npm run lerna-test

Related issues, RFCs

To catch #435
Built on top of #439

PR status

Is this ready for review?: YES
Is it a breaking change?: NO

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • I have added tests that prove my change is effective and works
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published in downstream module
  • The PR title follows the conventional commit semantics

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@github-actions github-actions bot added the internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) label Jan 10, 2022
@dreamorosi dreamorosi added the documentation Improvements or additions to documentation label Jan 10, 2022
@dreamorosi dreamorosi added this to the production-ready-release milestone Jan 10, 2022
dreamorosi
dreamorosi previously approved these changes Jan 10, 2022
Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a couple of minor suggestions on the CONTRIBUTING.md file, otherwise lgtm.

dreamorosi
dreamorosi previously approved these changes Jan 10, 2022
@flochaz flochaz force-pushed the chore/cicd/examplesTests branch from 385b27a to df65b1f Compare January 17, 2022 11:25
dreamorosi
dreamorosi previously approved these changes Jan 17, 2022
@flochaz flochaz requested a review from dreamorosi January 17, 2022 13:54
dreamorosi
dreamorosi previously approved these changes Jan 17, 2022
Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@flochaz flochaz requested a review from saragerion January 18, 2022 10:18
Copy link
Contributor

@ijemmy ijemmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you double check the npm install .. . I think it only installs commons package.

@flochaz flochaz merged commit 33d613b into main Jan 18, 2022
@flochaz flochaz deleted the chore/cicd/examplesTests branch January 18, 2022 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants