-
Notifications
You must be signed in to change notification settings - Fork 153
chore(examples): integrate in CI flow with lint and build #446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only a couple of minor suggestions on the CONTRIBUTING.md
file, otherwise lgtm.
385b27a
to
df65b1f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you double check the npm install ..
. I think it only installs commons
package.
Description of your changes
(built on top of #439)
Examples were not linted or built leading to missed bugs and compilation errors.
This PR homoganize the structure of cdk examples as well as make them lint and built the same way as modules.
It also add a job in e2e test workflow to test compilation of future published packages and avoid this kind of needed fix #470
How to verify this change
Related issues, RFCs
To catch #435
Built on top of #439
PR status
Is this ready for review?: YES
Is it a breaking change?: NO
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.